• Oriol Brufau's avatar
    [css-pseudo] Support inherited text decoration properties in ::marker · 896f37a4
    Oriol Brufau authored
    The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568
    that inherited properties that apply to text can be set on ::marker and
    should affect the marker text.
    
    Therefore, this patch allows text-decoration-skip-ink, text-emphasis,
    -webkit-text-emphasis-color, -webkit-text-emphasis-position,
    -webkit-text-emphasis-style, and text-shadow in ::marker.
    
    text-underline-position is not allowed despite being inherited because
    it doesn't affect underlines specified by ancestor elements. And since
    text-decoration-line is not allowed, it would be pointless.
    
    Bug: 1031667
    
    TEST=external/wpt/css/css-pseudo/marker-text-decoration-skip-ink.html
    TEST=external/wpt/css/css-pseudo/marker-text-emphasis.html
    TEST=external/wpt/css/css-pseudo/marker-text-shadow.html
    TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
    TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
    
    Some parsing tests fail because unprefixed text-emphasis hasn't been
    implemented. And some reftests fail in legacy because ::markers with
    'content: normal' are not implemented using actual text.
    
    Change-Id: I3bd7287f0e8164a7fac0ed84dd4ec0af57a34f2e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396125
    Commit-Queue: Oriol Brufau <obrufau@igalia.com>
    Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#805343}
    896f37a4
disable-layout-ng 52.8 KB