• Lukasz Anforowicz's avatar
    Rename test suite to a more correct CorbAndCorsExtensionBrowserTest. · 898c6f7d
    Lukasz Anforowicz authored
    Motivation for the changes in the CL:
    
    - "Allowlisting" in the old test suite name focused on only 1 out of 4
      parameters that the test cases are parametrized with (kAllowlisted,
      kOutOfBlinkCors, kAllowlistForCors, kDeriveOriginFromUrl).
    
    - "CrossOriginReadBlocking" focused only on CORB, when the test cases
      have already been covering also CORS (e.g. when covering the
      CorbAllowlistAlsoAppliesToOorCors feature).
    
    Changes in the CL:
    
    - The CrossOriginReadBlockingExtensionAllowlistingTest test suite is
      renamed to CorbAndCorsExtensionBrowserTest.  This test suite is
      parametrized (see TestParam enum).
    
    - The CrossOriginReadBlockingExtensionTest test suite is renamed to
      CorbAndCorsExtensionTestBase.  Most methods of the test suite
      are moved to the parametrized test suite (i.e. to
      CorbAndCorsExtensionBrowserTest).  InstallExtension method from
      the base and from the derived class is flattened.  InstallApp method
      is moved/inlined into the WebViewContentScript test case.
    
    - The following tests are moved from the non-parametrized test suite
      to the parametrized one:
        - FromBackgroundPage_NoSniffXml
        - FromForegroundPage_NoSniffXml
        - FromServiceWorker_NoSniffXml (note https://crbug.com/1051594)
        - ProgrammaticContentScriptVsWebUI
      Only the WebViewContentScript test case remains to be
      non-parameterized.
    
    Bug: 1061567
    Change-Id: Ifa9ab33de02de2b8900edbdd402d93f4edbcb5a7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119150
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#753310}
    898c6f7d
BUILD.gn 353 KB