• Xiaocheng Hu's avatar
    [LayoutNG] Fix off-by-one hit test failure at vertical-rl line edges · 89a28385
    Xiaocheng Hu authored
    The hit test "point" is not really a point, but a pixel with 1px width
    and height. Ignoring this leads to off-by-one errors when converting
    a physical point into logical in vertical-rl writing mode.
    
    This patch fixes the issue by using 1px width and height in the
    conversion, instead of 0.
    
    Note: This patch contains an all-pass NG baseline because the legacy
    baseline contains a failure line.
    
    Bug: 811502
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ie3f01469b4902c3c9647d40be92ccb9c26467f0d
    Reviewed-on: https://chromium-review.googlesource.com/1150814
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#578178}
    89a28385
enable-blink-features=LayoutNG 70.9 KB