• Ilya Sherman's avatar
    Revert "Revert "[Variations] Avoid duplication of the safe seed value stored in prefs."" · 89ab8862
    Ilya Sherman authored
    This reverts commit 92ffe77a.
    
    Reason for revert: I suspect that the original revert was inappropriate – more detailed reasoning left as a review comment on the revert CL.
    
    Original change's description:
    > Revert "[Variations] Avoid duplication of the safe seed value stored in prefs."
    > 
    > This reverts commit 4db68ed9.
    > 
    > Reason for revert: Seems to cause failures on Mac ASan 64 Tests (see crbug.com/806712).
    > 
    > Original change's description:
    > > [Variations] Avoid duplication of the safe seed value stored in prefs.
    > > 
    > > When the safe seed and the latest seed have identical contents, use a sentinel
    > > value to avoid storing a duplicate value for the two seeds. This is purely a
    > > storage space optimization; no difference in observed functionality is expected.
    > > 
    > > R=​asvitkine@chromium.org
    > > 
    > > Bug: 727984
    > > Change-Id: Ica641a479228b0cdfcc4af2ec04ddfc54c36c5eb
    > > Reviewed-on: https://chromium-review.googlesource.com/880482
    > > Commit-Queue: Ilya Sherman <isherman@chromium.org>
    > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#532027}
    > 
    > TBR=isherman@chromium.org,asvitkine@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 727984, 806712
    > Change-Id: Ic5de33c61bb2acf88d7445ded4f0a1743ab7f456
    > Reviewed-on: https://chromium-review.googlesource.com/891119
    > Reviewed-by: vitaliii <vitaliii@chromium.org>
    > Commit-Queue: vitaliii <vitaliii@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#532401}
    
    TBR=isherman@chromium.org,asvitkine@chromium.org,vitaliii@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 727984, 806712
    Change-Id: I1627111dacc8d59bc43aa7b1b7ed76db8f165ee2
    Reviewed-on: https://chromium-review.googlesource.com/894622Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
    Commit-Queue: Ilya Sherman <isherman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#533098}
    89ab8862
variations_seed_store_unittest.cc 48.9 KB