• thakis's avatar
    Work around a clang/win bug, add a .h file to gyp/gn files. · 8a0f0753
    thakis authored
    clang can't handle dllexported classes with only member initializers yet
    (see crbug and http://llvm.org/PR23542). As a workaround, don't dllexport
    this class.  This has the effect of emitting the class's constructor into
    every translation unit that uses it instead of just every translation unit of
    the media component, but in a way that seems nicer anyways since there's no
    .cc file for this header and so currently this relies on some translation unit
    in media including this header by lucky accident (else the constructor wouldn't
    be defined anywhere.)
    
    Once the clang bug is fixed we can consider adding this back; in the meantime
    this seems like a tiny price to pay to get the bots back green.
    
    Also add the .h file to the relevant gyp/gn files, else the analyze
    step will make the trybots think that nothing changed when this
    .h file is touched.
    
    BUG=488634,467779
    TBR=sandersd
    
    Review URL: https://codereview.chromium.org/1133423003
    
    Cr-Commit-Position: refs/heads/master@{#330299}
    8a0f0753
BUILD.gn 13.5 KB