• Tommy C. Li's avatar
    Omnibox: Make OmniboxView::GetIcon more robust for steady state elisions · 8a1133a0
    Tommy C. Li authored
    Whenever the user unelides the URL, the omnibox also enters
    user_input_in_progress_ mode.
    
    This is was harmless before, but since then we have started displaying
    suggestion favicons in the omnibox, the current page's security
    indicator is being clobbered by the page's favicon during unelision.
    
    This is not correct, since unelision is supposed to be as unobtrusive
    as possible.
    
    This is going to become more noticable now that Ctrl+L triggers
    unelision, as well as our future planned work for One-Click-Unelide.
    
    This CL replaces the old logic, and keeps showing the current page's
    security indicator until the user actually modifies the user text.
    
    Bug: 874592, 906223, 910145
    Change-Id: I8a5619d4408b09d2e9f98fd5ce011ecbd2cab085
    Reviewed-on: https://chromium-review.googlesource.com/c/1351564
    Commit-Queue: Tommy Li <tommycli@chromium.org>
    Reviewed-by: default avatarKevin Bailey <krb@chromium.org>
    Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
    Reviewed-by: default avatarBen Wells <benwells@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#613203}
    8a1133a0
omnibox_edit_model.cc 68.9 KB