• Hiroki Nakagawa's avatar
    Prerender: Ignore results of ExecJs() to fix flaky browser tests · 8a21aac7
    Hiroki Nakagawa authored
    To deflake browser tests, this CL makes NavigationWithLocation() helper
    ignore the result of ExecJs().
    
    The helper is used for activating prerendered pages. Depending on
    timing, activation could destroy the current WebContents before ExecJs()
    gets a result from the frame that executed scripts. This results in
    execution failure even when it actually succeeded. This part will
    drastically be modified by the MPArch, so this CL takes the approach
    just to ignore it instead of fixing the timing issue. When ExecJs()
    actually fails, the remaining test steps should fail, so it should be
    safe to ignore it.
    
    Bug: 1156141
    Change-Id: Ia9c72ccd161b29f9fde4481cbc3e4fae4167fb0a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593796Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#837494}
    8a21aac7
prerender_browsertest.cc 14.2 KB