• Alexey Baskakov's avatar
    Revert "desks: Fix crash when touchpad swipe with external monitors." · 8a280610
    Alexey Baskakov authored
    This reverts commit 9771027b.
    
    Reason for revert: Breaks ash_unittests on ASAN bots (use after free)
    https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/39004/overview
    
    Original change's description:
    > desks: Fix crash when touchpad swipe with external monitors.
    >
    > The crash was because a new screenshot is requested when the current
    > screenshot is about to get scrolled out of bounds. It was using a fixed
    > number threshold, meaning displays that are not the same size could
    > get out of sync easily, leading to a CHECK failure.
    >
    > This CL addresses that by requesting screenshot on all displays if even
    > one of them needs one. Another approach would be change the spacing and
    > threshold to be based on the display width instead of fixed number, but
    > that could be prone to roundoff error which may cause a similar issue.
    >
    > Also noticed visible desk metric was double counting when there are
    > multiple displays. Added a TODO for that one as it is lower priority.
    >
    > Bug: 1154868
    > Test: manual, added regression test
    > Change-Id: I48f5ef62d3284b710f44a2808f75c95686bc9b3d
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570551
    > Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#833993}
    
    TBR=afakhry@chromium.org,sammiequon@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1154868
    Change-Id: I23cf043d8bc4ae5c9ed8531429b9ffcee43224e4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575778Reviewed-by: default avatarAlexey Baskakov <loyso@chromium.org>
    Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#834100}
    8a280610
desk_animation_base.cc 5.1 KB