-
Jinsong Fan authored
There two cases of the bug: 1. When the touch handles are on the same line, or one of them is invisible, the RectBetweenBounds becomes a line, and not union the handle rect, cause the context menu covers the touch handles. 2. Long press on any text, the showSelectionMenu is coming before concluding the selection. While the handles remain hidden for the duration of a longpress drag, including the time between a longpress and the start of drag motion. So, the handle rect is empty and cause the context menu covers the touch handles. The CL removes the empty check of RectBetweenBounds, so it always union the handle rect to fix case 1. For case 2, leave it to Ajith's CL to fix(http://crrev/c/995653). Bug: 1013477 Test: manual Change-Id: Ie4fbe0669b28d1a0e7ac0894d2ba07569b63dd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857838 Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#709760}
8a702487