GitLab

LoadDataWithBaseURL should be avoided in browser tests, because
1. It doesn't fully, correctly simulate navigating to a real website.
2. It is only used in production in Android WebView and in GuestView
   (both of which don't run with site-per-process, which is the default
    mode on desktop platforms).

Cleaning up test usage of LoadDataWithBaseURL will help proceed with
enforcement of CanCommit origin checks - LoadDataWithBaseURL is
problematic because it commits https://foo.com origin in a SiteInstance
associated with data: site URL.

Bug: 770239
Change-Id: Ic68697be28cace0d8ff8abc0951e12cb5f81ac68
Reviewed-on: https://chromium-review.googlesource.com/c/1385471Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618336}