• liberato@chromium.org's avatar
    Revert "Switch VideoFrameFactoryImpl to use a SharedImageVideoProvider" · 8ac910dc
    liberato@chromium.org authored
    This reverts commit 579b12b9.
    
    Reason for revert: crbug.com/968470 (want to revert before branch cut)
    
    Original change's description:
    > Switch VideoFrameFactoryImpl to use a SharedImageVideoProvider
    > 
    > This CL creates DirectSharedImageVideoProvider, which does a hop to
    > the gpu main thread for every SharedImageVideo request.  This is
    > almost identical to what was happening before, just refactored.
    > 
    > GpuVideoFrameFactory is now an implementation detail of the provider
    > rather than VideoFrameFactoryImpl.
    > 
    > A follow-up CL will provide an implementation of
    > SharedImageVideoProvider that maintains a pool of SharedImageVideo
    > objects to provide without hopping to the gpu main thread on the
    > critical path.  It will still post a "MaybeRenderEarly" to the main
    > thread, but that doesn't need to hold up delivery of the VideoFrame
    > to the renderer.
    > 
    > Change-Id: Ia318862daf610327e716515f020b3eeb934dd012
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628154
    > Commit-Queue: Frank Liberato <liberato@chromium.org>
    > Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#663361}
    
    TBR=dalecurtis@chromium.org,liberato@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I2c7878a5f6a31c2b4518a9756f144891a6341863
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636561Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
    Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#664900}
    8ac910dc
video_frame_factory_impl.cc 18.4 KB