• Friedrich Horschig's avatar
    Revert "Remove redundant OnEndEditingTextfield event" · 8b10e3c6
    Friedrich Horschig authored
    This reverts commit 76648dac.
    
    Reason for revert: As described in crbug.com/1056527, Android WebView still relies on this. An upstream fix is too risky so I'll revert this CL for now.
    
    Bug: 1056527
    
    Original change's description:
    > Remove redundant OnEndEditingTextfield event
    >
    > The event OnEndEditingTextField seems to be redundant (esp. with focus
    > changes) and isn't correct in all cases: If users interact with native
    > UI like an autofill dropdown, the event will try to close this piece of
    > UI although this isn't always necessary.
    >
    > This CL therefore removes the event which allows dropdowns to remain
    > open after interaction if they require it (e.g. see use case in linked
    > bug).
    >
    > Bug: 1043963
    > Change-Id: I5c7a6ede34fb574bd3f91d4b16fbb4e2a78a8d24
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034527
    > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    > Reviewed-by: Alex Gough <ajgo@chromium.org>
    > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#738105}
    
    TBR=vasilii@chromium.org,dvadym@chromium.org,fhorschig@chromium.org,ajgo@chromium.org
    
    Bug: 1043963
    Change-Id: I3bf88ec43fa6ae9bf0d11f295bc1b0debbba71ce
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087331Reviewed-by: default avatarFriedrich [CET] <fhorschig@chromium.org>
    Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#746712}
    8b10e3c6
form_autocomplete_browsertest.cc 33.9 KB