GitLab

Currently, an active impression is approximated by whenever the menu or
the Quick Answer is dismissed without clicking on a menu-item. This
indicates user could be actively looking for Quick-Answers instead of
any other menu operation.

This is currently buggy because DismissQuickAnswers() overcounts the
metric even when a Quick-Answer was not shown to the user (because the
User-Consent view was shown instead).

This CL ensures that the metric is not overcounted by fixing that, and
also ensures this change will not lead to under-counting by routing the
view-close operations via DismissQuickAnswers() where logging happens.

Bug: b:158265647
Test: Tested on Chrome OS VM.
Change-Id: Ieed9356fbb64650b521c893a44e83caa49ea831e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233342Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
Cr-Commit-Position: refs/heads/master@{#775799}