• Stephane Zermatten's avatar
    [Autofill Assistant] Fix selector when using Autofill in an iframe. · 8bf35ae9
    Stephane Zermatten authored
    Before this patch, WebController could not find the form data if that
    form data was in an iframe. The logic that cleaned up the selector of
    the element that was clicked on to pass to GetElementFormAndFieldData
    didn't trigger, as the frame index reported in FindElementResult was 0.
    
    This patch takes another approach: it always only pass the last selector
    to GetElementFormAndFieldData, which should make sense, since we're in
    the same context as the element that was clicked on.
    
    With this patch, Autofill works even when forms are in an iframe.
    
    Bug: 806868
    Change-Id: Ic7deaf863373659e9143c38cf01a6ca1406e6521
    Reviewed-on: https://chromium-review.googlesource.com/c/1264600
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#597164}
    8bf35ae9
web_controller.cc 30.4 KB