GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/7411aeba4d3b..e6f794f1dc5d

2020-10-19 treehugger-gerrit@google.com Merge "test: Make IPC dependency optional"
2020-10-19 treehugger-gerrit@google.com Merge "metrics: Convert RAILMode query to use protos"
2020-10-19 skyostil@chromium.org test: Remove unneeded traced.h includes am: 9aeedae636
2020-10-16 oysteine@google.com Merge "gn: Don't build end_to_end_integration test in Chrome" am: db25661ba2
2020-10-16 primiano@google.com Merge "Remove ODR violations from Bazel builds" am: 112daf7c04
2020-10-16 skyostil@google.com Merge "gn: Guard client_api_example target configuration" am: 7863f8fb8b
2020-10-16 salg@google.com Merge "proto/processor: Add ChromeWindowHandleEventInfo" am: 8065f31f44
2020-10-15 lalitm@google.com tp: add support for ingesting and using kernel symbols am: 24305ca78e
2020-10-15 skyostil@google.com Merge "tracing: Add debug check for duplicated interned data indices" am: 51f19948ce
2020-10-15 hjd@google.com Merge "ui: Support multiple thread tracks" am: 81c6a09c12
2020-10-15 treehugger-gerrit@google.com Merge "tracing: Implement system consumer backend" am: 823dd74cd7
2020-10-14 treehugger-gerrit@google.com Merge "tracing: Handle producer disconnection" am: 7411aeba4d
2020-10-14 hjd@google.com Merge "Add fastrpc_dma_stat" am: 0581509dc2
2020-10-14 hjd@google.com Merge "ui: Improve rendering of incomplete slices" am: 825d78c0eb
2020-10-14 taylori@google.com Roll trace processor am: ca4153fa8b
2020-10-14 treehugger-gerrit@google.com Merge "Add a new proto for ChromeRendererSchedulerState" am: a4ac7a10c9
2020-10-14 simonmacm@google.com Merge "Update ugly suspend-resume heuristic for newer kernels." am: 00cd6e6114
2020-10-14 hjd@google.com Merge "ui: Fix SQL query escaping" am: 1410c33130
2020-10-14 hjd@google.com Merge "ui: Download trace in new tab" am: 1bf2339dc0
2020-10-14 skyostil@chromium.org tracing: Don't try to observe events before connecting am: 363c2bd3d7
2020-10-14 primiano@google.com Merge "init: mkdir /data/misc/perfetto-configs" am: 19ee1c9458
2020-10-13 treehugger-gerrit@google.com Merge "docs: fix instructions for adb shell perfetto" am: 0150a791fc
2020-10-13 treehugger-gerrit@google.com Merge "ipc: Fix use-after-free on connection failure" am: 095444c212
2020-10-13 treehugger-gerrit@google.com Merge "tracing: Don't reuse trace writers across connections" am: a08dc37d19
2020-10-12 treehugger-gerrit@google.com Merge "tp: implement async track set tracker" am: a4b8d27d96
2020-10-12 hjd@google.com perfetto_cmd: Fix statsd based triggers am: 7c7b98f060
2020-10-09 fmayer@google.com Merge "Document LD_PRELOAD heapprofd library." am: 109c355900
2020-10-09 fmayer@google.com Merge "Allow to set base pointer for referred objects." am: 667f89a6e8
2020-10-09 ngeoffray@google.com Merge "Add liblog as a dependency of libperfetto_client_experimental." am: aef1b91502
2020-10-09 treehugger-gerrit@google.com Merge "Fix missing __libc_posix_memalign symbol." am: 815983783a
2020-10-09 treehugger-gerrit@google.com Merge "Build heapprofd_preload when building heapprofd." am: 978e713841
2020-10-09 treehugger-gerrit@google.com Merge "Fix slice combining in RAIL mode metric" am: 0ad07c9245
2020-10-09 primiano@google.com Merge "Add support for symbolizing kernel symbols for ftrace events" am: c251d370b6
2020-10-09 treehugger-gerrit@google.com Merge "Added key navigation for flow events" am: 2bf76269e1
2020-10-09 treehugger-gerrit@google.com Merge "Skip ab/6749736 in stage." into stage-aosp-master
2020-10-09 treehugger-gerrit@google.com Merge "trace_to_text: make endian functions portable" am: 7c2d888fdf
2020-10-08 treehugger-gerrit@google.com Merge "Add missing beginPath when drawing instant event arrows" am: 628c64d7a1
2020-10-08 fmayer@google.com Merge "Do not abort profile if main thread stack grows." am: 02a7aa75bb
2020-10-08 primiano@google.com Merge changes Ic7aa1265,I4d418aac am: 8cf1557a5c
2020-10-08 treehugger-gerrit@google.com Merge "perfetto-ui: Improve record page" am: 42e5254db8
2020-10-08 treehugger-gerrit@google.com Merge "hprof converter skeleton" am: 823a6df243
2020-10-08 primiano@google.com Merge "gn: Apply visibility rules to gn:default_{deps,config}" am: f2eb31d857
2020-10-08 fmayer@google.com Improve docs about runtime signalling. am: 31b44b3a70
2020-10-07 treehugger-gerrit@google.com Merge "get.perfetto.dev: filter out urls" am: 9fb07662e4
2020-10-07 treehugger-gerrit@google.com Merge "processor: Update descriptor track names from first event's name" am: 2cb8216a1b
2020-10-07 primiano@google.com Merge "build: Remove no-op calls to set_sources_assignment_filter" am: 3419b3b485
2020-10-07 ddrone@google.com Merge "Manually copy Chrome extensions to Perfetto" am: b64eb281be
2020-10-07 oksamyt@google.com Merge "[trace processor] Remove unused code from the WebView power metric" am: 91ab730685
2020-10-07 hjd@google.com Merge "ui: Fix <O recording docs link" am: b364d20b12
2020-10-07 treehugger-gerrit@google.com Merge "Fix build failure due to extra parent dir" am: 6e7d3e86fc
2020-10-06 treehugger-gerrit@google.com Merge "perfetto-ui: Move query result to details panel" am: 8673284abb
2020-10-06 lalitm@google.com Merge "tp: fix type affinity of string columns" am: 6632b1c5b5
2020-10-05 ssid@google.com Add a typed event for mojo notify event am: 77ab7cfe84
2020-10-05 cfijalkovich@google.com Merge "Calibrate HSC-emulated app launch measurements" am: d53debd86f
2020-10-05 treehugger-gerrit@google.com Merge "Added new proto format for flow events" am: aeb4a3e63d
2020-10-05 treehugger-gerrit@google.com Merge "Added category and name columns for flow details panel" am: aa07f43f0b
2020-10-05 ilkos@google.com Merge "Fix quantization error" am: 78d8e2c4fe
2020-10-05 lalitm@google.com Merge "tp: wait to fill buffers when parsing gzip before sending to next stage" am: 7c0969160a
2020-10-05 hjd@google.com Merge changes I4f8eb249,I829c77e0 am: 9939fa32b2
2020-10-05 hjd@google.com Merge "ui: Stitch small TraceHttpStream chunks" am: 7cdc44f903
2020-10-05 treehugger-gerrit@google.com Merge "[trace processor] Add RAIL Mode power metrics" am: af6c5c6227
2020-10-02 treehugger-gerrit@google.com Merge "ui: Bump state version for metrics changes" am: 1f8d793e3b
2020-10-02 treehugger-gerrit@google.com Merge "Reduce max frame count." am: e9d7296b17
2020-10-02 treehugger-gerrit@google.com Merge "Optimize the scroll_jank_cause_queuing_delay metric." am: 3b50b7c411
2020-10-02 treehugger-gerrit@google.com Merge "Reserve space for frames in AllocRecord." am: 9b8970cc01
2020-10-02 hjd@google.com Merge "ui: Search within slice args" am: c0482f7bd1
2020-10-02 treehugger-gerrit@google.com Merge "Add memory snaphot tables." am: 2e66e50062
2020-10-02 taylori@google.com Merge "perfetto-ui: Fix details panel height" am: 935a915963
2020-10-02 hjd@google.com Merge "Remove extra join" am: df861c5206
2020-10-01 fmayer@google.com Merge "Allow to use data_source_stop_timeout_ms in java_heap_dump." am: d2958971d9
2020-10-01 treehugger-gerrit@google.com Merge "perfetto_cmd: Use monotime for sendfile timeout" am: ed322fe3fa
2020-10-01 treehugger-gerrit@google.com Merge "Add missing stddef.h header in compiler.h" am: 7917fa2dd4
2020-10-01 treehugger-gerrit@google.com Merge "processor: Update null names of legacy Chrome async tracks on lookup." am: d184e4ba02
2020-10-01 hjd@google.com Merge "ui: Improve track names even more" am: 72a6843cad
2020-10-01 lalitm@google.com Merge "Update CHANGELOG for v8.0 release" am: 9d0f922886
2020-10-01 fmayer@google.com Merge "Pull heapprofd simpleperf into output directory." am: bce69fefbe
2020-10-01 hjd@google.com Merge "Revert "ui: Add gn rule to copy protobufjs light"" am: a321d9ae25
2020-10-01 hjd@google.com Merge "ui: Improve track names" am: c6475d45a9
2020-10-01 taylori@google.com Merge "perfetto-ui: Order thread tracks" am: f01bf538a4
2020-10-01 hjd@google.com Merge "ui: Don't go via trackState for trackState.id" am: 2fde3fac99
2020-09-30 oksamyt@google.com Merge "[trace processor] Add Webview-only thread usage to WV power metric" am: 492d4a85a2
2020-09-30 taylori@google.com Roll trace processor am: 670e999072
2020-09-30 treehugger-gerrit@google.com Merge "Aggregate flamegraph by name rather than type id." am: 810b74c0d7
2020-09-30 taylori@google.com Merge "ui: Don't allow selection in the track shell area" am: adc22042d0
2020-09-29 treehugger-gerrit@google.com Merge "ui: Add a metrics page" am: bb5318dbbf
2020-09-29 treehugger-gerrit@google.com Merge "Use CPU/wall time to descend TRACE_EVENTs when multiple children exist" am: 5b2eba1831
2020-09-29 dproy@google.com Merge "HistogramName interning" am: 6f3ac1001f
2020-09-29 treehugger-gerrit@google.com Merge "Added dynamic tables for preceding and following flows" am: 68983d39e5
2020-09-29 treehugger-gerrit@google.com Merge "Fix typescript error" am: 76404b01d5
2020-09-28 treehugger-gerrit@google.com Merge "Fixed data source index assert checking against wrong constant." am: 88c194fccd
2020-09-28 cferris@google.com Merge "Update for libunwindstack change." am: 7ec44b1e23
2020-09-25 treehugger-gerrit@google.com Merge "flamegraph: Compress text if it almost fits" am: df3ae5e6f9
2020-09-25 hjd@google.com Merge "flamegraph: Reduce font size and improve rollover rendering" am: d3fe2d1611
2020-09-25 treehugger-gerrit@google.com Merge "Add a query that will compute the CPU time per chrome thread slice." am: fe40be6924
2020-09-25 fmayer@google.com Merge "Document weird looking if condition." am: c2e629442d
2020-09-25 fmayer@google.com Merge "Include data_source_stop_timeout_ms in perfetto cmd TTL." am: d62c73fbf4
2020-09-25 lalitm@google.com Merge "Make operator- const" am: a701e9d0da
2020-09-25 taylori@google.com Merge "perfetto-ui: Warn user about old TP version" am: 0e384eef5e
2020-09-25 hjd@google.com Merge "ui: Fix bug with computing maxDepth" am: c49e606913
2020-09-25 fmayer@google.com Merge "Add field to ignored types in perfetto_hprof." am: 8718dc4d41
2020-09-25 hjd@google.com Merge "Reland: Make GuessTraceType more selective about proto traces" am: 8f47f320f6
2020-09-24 hjd@google.com Merge "ui: Swallow key events on crash dialog" am: df53732e1b
2020-09-24 treehugger-gerrit@google.com Merge "Fix GPU memory metrics aggregation" am: d6e5d04ae0
2020-09-24 taylori@google.com Merge "perfetto-ui: Make metrics non-breaking in UI" am: 71ee049b6b
2020-09-24 hjd@google.com Merge changes I3ac1b577,I174ae837,I9d1f40a5 am: 63017f32d1
2020-09-24 taylori@google.com Merge "Load trace and discard old state" am: 92706a8994
2020-09-24 treehugger-gerrit@google.com Merge "Remove doc references to ftrace wildcard feature." am: 3d8fd27d9a
2020-09-24 treehugger-gerrit@google.com Merge "Ftrace: don't log errors in case of ENODEV" am: f6b292d8a3
2020-09-23 dproy@google.com Merge "metrics: Implement getting prototext formatted metric result" am: 4e32ab4dd7
2020-09-23 fmayer@google.com Merge "Also deobfuscate frames from jit-cache." am: 61c15b0ea0
2020-09-23 primiano@google.com Merge "Update libcxx, libcxxabi, libunwind, clang-format" am: 637111bf30
2020-09-23 fmayer@google.com Add Known Issue about sampling_interval_bytes=0. am: 12494ee122
2020-09-23 hjd@google.com Merge "Revert "Make GuessTraceType more selective about proto traces"" am: 06f3474ec4
2020-09-23 hjd@google.com Merge "Make GuessTraceType more selective about proto traces" am: e6fa5ff79a
2020-09-23 lalitm@google.com Merge "perfetto: bump integration test timeout" am: 8b4b90b0a0
2020-09-23 fmayer@google.com Merge "Allow to specify separate sampling interval per heap." am: eb7e0e1acb
2020-09-23 taylori@google.com ui: Fix logs panel am: e5e5768709
2020-09-23 treehugger-gerrit@google.com Merge "Update clang to llvmorg-12-init-5035-gd0abc757-3" am: d937502d15
2020-09-23 hjd@google.com Merge "Remove Dropbox code from android_internal" am: fd86b8d464
2020-09-23 taylori@google.com Merge "perfetto-ui: Only intialize GA on prod or staging" am: 90adb47e5d
2020-09-22 oysteine@google.com Merge "New/Updated typed arg types for Chrome" am: 4f973a50bb
2020-09-22 treehugger-gerrit@google.com Merge "Larger default buffer config in UI." am: 3c7133e86f
2020-09-22 fmayer@google.com Merge "Have separate sampler per heap." am: 82c70d9757
2020-09-22 taylori@google.com Merge "ui: Don't show reload toast" am: ada5d5129f
2020-09-22 hjd@google.com Merge "ui: Improve error message for invalid permalink" am: 9cf7a56afb
2020-09-22 hjd@google.com Merge "Support loading traces from the Android Bug Tool" am: 791ed207e2
2020-09-21 treehugger-gerrit@google.com Merge "Two small fixes for pages with a 16KB system page" am: b653fdea2f
2020-09-21 treehugger-gerrit@google.com Merge "ui: Implement debug slices track" am: 6a7b87067b
2020-09-21 treehugger-gerrit@google.com Merge "ui: Make it impossible to select the close permalink button" am: 2d461fa4a0
2020-09-21 treehugger-gerrit@google.com Merge "Background mode for busy_threads" am: f2db91bc8a
2020-09-21 treehugger-gerrit@google.com Merge "Always add a "args" dictionary even if empty." am: 5721bfd7a5
2020-09-21 hjd@google.com Merge "Reland code changes for mithril v2.0" am: d485436734
2020-09-21 fmayer@google.com Merge "Do not crash on missing root for flamegraph." am: 7f3209db71
2020-09-18 fmayer@google.com Merge "Add multi ABI fix to changelog." am: c7865d989c
2020-09-18 hjd@google.com Revert "Revert "Revert "ui: Upgrade mithril 1.0.2 -> 2.0.3""" am: 8b14ed3b82
2020-09-17 fmayer@google.com Merge "Make sure we are using the correct stack base." am: bced72b4fb
2020-09-17 primiano@google.com Merge "Docs: minor fix to the benchmark code" am: 3bcddbcefc
2020-09-17 rslawik@google.com Require core layout for time in state metric am: e8d5e6f521
2020-09-17 fmayer@google.com Rename all occurences of client_ext. am: 40c612f34e
2020-09-17 lalitm@google.com Merge "tp: add support for shell on Android" am: 2f37178ebd
2020-09-17 fmayer@google.com Merge "Rename client_ext.h to heap_profile.h." am: 511274afd2
2020-09-17 fmayer@google.com Add missing fields from comparator for AllocMetadata. am: b85952a45e
2020-09-17 treehugger-gerrit@google.com Merge "perfetto-ui: Fix null keyed fragments" am: 6280abf226
2020-09-17 treehugger-gerrit@google.com Merge "Allow to write out profiles from HeapprofdEndToEnd." am: c97e37f982
2020-09-17 treehugger-gerrit@google.com Merge "Exporting flow events to json from flow table" am: 29e4a94d1e
2020-09-17 fmayer@google.com Merge "Rename com.android.malloc -> libc.malloc." am: 05efd8600d
2020-09-17 treehugger-gerrit@google.com Merge "Flow events are highlighted when slice is hovered" am: d62add52c6
2020-09-16 treehugger-gerrit@google.com Merge "tp: switch from using libprotoc to libprotobuf-full" am: a2ba0ce189
2020-09-16 fmayer@google.com Merge changes I26d1c6e5,I9ceaa1ff am: 3504e85b74
2020-09-16 treehugger-gerrit@google.com Merge "Fixed mouse hover over slice" am: b14a3f7cf6
2020-09-16 treehugger-gerrit@google.com Merge "Log unwinding errors in heapprofd e2e test." am: 098b75940d
2020-09-16 treehugger-gerrit@google.com Merge "probes: update vmstat counters to latest 4.14 and 4.19" am: 33010a1b33
2020-09-16 hjd@google.com Merge "perfetto_cmd: Remove Dropbox upload code" am: 7d73d47538
2020-09-16 primiano@google.com Merge "iorap API: fix thread race when initializing the consumer library" am: d1382ae74f
2020-09-16 treehugger-gerrit@google.com Merge "Roll trace processor" am: 144228061e
2020-09-16 treehugger-gerrit@google.com Merge "Fix broken default query." am: 38f0f40310
2020-09-16 fmayer@google.com Merge "Clarify experimental_flamegraph example." am: 5e931ebb24
2020-09-16 treehugger-gerrit@google.com Merge "require_root for perfetto_integrationtests." am: d48ef5f7dd
2020-09-15 fmayer@google.com Merge "Fix invalid CHECK in flamegraph generation." am: b189aac831
2020-09-15 hjd@google.com Merge "ui: Fix logcat dropdown" am: a309fd95e9
2020-09-15 taylori@google.com Merge "Revert "ui: Upgrade immer from 1.12.0 -> 7.0.8"" am: e3da35d534
2020-09-15 taylori@google.com Merge "perfetto-ui: Column sums" am: e049f9d1de
2020-09-15 taylori@google.com Merge "perfetto-ui: Add privacy policy link" am: dfc49d1714
2020-09-15 taylori@google.com perfetto-ui: Add isGoogler custom dimension am: 79cef0a5cf
2020-09-15 lalitm@google.com Merge "tp: remove hack of stripping prefix for --run-metric files" am: df4ddebf1c
2020-09-15 fmayer@google.com macOS linker does not have -Wl,--build-id. am: b0a548c7e6
2020-09-15 hjd@google.com Merge "ui: Upgrade immer from 1.12.0 -> 7.0.8" am: 346ff6a4d7
2020-09-15 treehugger-gerrit@google.com Merge "cppgen: Don't require full submessage definitions in gen headers" am: 53913fb84a
2020-09-14 treehugger-gerrit@google.com Merge "Generate build ids." am: cfda0b2aaf
2020-09-14 fmayer@google.com Merge "Count how long we sleep for the client spinlock." am: 10bc2ded1f
2020-09-14 lalitm@google.com Merge "bazel: cleanup duplicate proto deps" am: ef8430ec39
2020-09-14 fmayer@google.com Merge "Separate allocator wrapping logic from Bionic." am: fc73b4f240
2020-09-14 hhb@google.com Merge "Using DoAll" am: 68550030dc
2020-09-14 treehugger-gerrit@google.com Merge "TrackEvent: Add support for overriding interned data storage" am: 10df243381
2020-09-14 lalitm@google.com Merge "ui: fix exponential memory usage for async slice tracks" am: ff21c0b51d
2020-09-14 lalitm@google.com metrics: explicitly specify source_set generator for all metric protos am: eeae1e0ad1
2020-09-14 treehugger-gerrit@google.com Merge "tp: migrate chrome metrics descriptor generation to build time" am: 4934cd57c7
2020-09-14 treehugger-gerrit@google.com Merge "Add some additional special classes to histogram" am: 8d39c21bc7
2020-09-14 lalitm@google.com Merge "tools: replace \ with _ in include guard as well" am: bef393a5a3
2020-09-14 treehugger-gerrit@google.com Merge "Displaying Flow Events in the UI" am: 662cb23c78
2020-09-14 lalitm@google.com Merge "gn: make generate_descriptor consistent between chrome and standalone" am: a2c843670e
2020-09-11 treehugger-gerrit@google.com Merge "chrome_config: Add client priority setting" am: da650d02a5
2020-09-11 fmayer@google.com Merge "Check whether all allocations are sampled for accurate test." am: d7a7a09b81
2020-09-11 hjd@google.com Merge "ui: Fix build dependencies" am: af8f83971e
2020-09-11 lalitm@google.com Merge "tp: add missing array header" am: 66cccba08f
2020-09-11 lalitm@google.com Merge "as_pandas() -> as_pandas_dataframe(); add __str__ representation" am: 7c81d93f11
2020-09-11 lalitm@google.com Merge "tp: move metrics descriptor generation to build time" am: 251239c02c
2020-09-11 fmayer@google.com Remove outdated comment. am: 9edd1a906f
2020-09-11 hjd@google.com Fix clock_tracker.cc am: 5dc147f282
2020-09-11 ssid@google.com Merge "Avoid race in accessing log count" am: bb36b6a3f4
2020-09-11 zzyiwei@google.com Define GPU metrics am: 617d3f67c3
2020-09-11 zzyiwei@google.com Fix the scope of counter_span_view am: 48a955aeb0
2020-09-11 treehugger-gerrit@google.com Merge "tp: add support for gzipped traces in DecompressTrace" am: a4cfaa2dfc
2020-09-11 fmayer@google.com Merge changes Ief0ffa2c,Icce0f62c am: 3b19b9d334
2020-09-11 hjd@google.com Merge "Remove d8, we never used it" am: 8bfaef6ad5
2020-09-11 hjd@google.com Merge "ui: Add --incremental to TypeScript build" am: a6222ca1f5
2020-09-11 delphij@google.com [automerger skipped] Merge "Merge Android R" am: 93b70685b2 -s ours
2020-09-10 treehugger-gerrit@google.com Merge "ui: Add support to decode metrics in the UI" am: e89d2e06c6
2020-09-10 treehugger-gerrit@google.com Merge "metrics: Extend metric proto before registering metric" am: feb1579dfb
2020-09-10 treehugger-gerrit@google.com Merge "traceconv: add missing flush in output writer" am: 5f2455899f
2020-09-10 treehugger-gerrit@google.com Merge "Add back reserved lines commented earlier" am: e25084872a
2020-09-10 treehugger-gerrit@google.com Merge "tp: extract out tokenizing logic from ProtoTraceTokenizer" am: 625eb19759
2020-09-10 lalitm@google.com ui: don't throw exception for zero-duration instants am: df5b7cb44e
2020-09-10 rslawik@google.com Merge "Fix unique constraint failed error" am: b3f3e76c87
2020-09-10 ssid@google.com Merge "Add source location as typed event argument" am: d07b48d3ed
2020-09-10 taylori@google.com Merge "ui: Use id for thread state selection" am: 94d84fc8ff
2020-09-10 treehugger-gerrit@google.com Merge "UI: allow ?=&; chars from postMessage strings" am: f2fd649d1f
2020-09-10 treehugger-gerrit@google.com Merge "Use deobfuscated symbol name in callsites" am: 8d1bf91b4d
2020-09-10 treehugger-gerrit@google.com Merge "Add a smoothness flag to per-frame state." am: e6cf965855

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Id76be450bd1c3bf503f2e33c26d85e69c393513a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486191Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818646}