• Sylvain Defresne's avatar
    Reland "[ios] Remove dependency of Showcase on //ios/chrome/app:app_internal" · 8c62eafd
    Sylvain Defresne authored
    This is a reland of 95ba7404
    
    Original change's description:
    > [ios] Remove dependency of Showcase on //ios/chrome/app:app_internal
    > 
    > Showcase should not depend on //ios/chrome/app (except for the hooks).
    > The dependencies were unnecessary and can be safely removed (after the
    > removal of one stale #include).
    > 
    > After this CL, there is no dependency on //ios/chrome/app:app_internal:
    > 
    >   $ gn path out/Debug-iphonesimulator --all \
    >       //ios/showcase:ios_showcase_egtests \
    >       //ios/chrome/app:app_internal
    >   No non-data paths found between these two targets.
    > 
    > Bug: 870935
    > Change-Id: I586fe8da7ce2e74dae2cedfd9720044afa97650f
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067264
    > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
    > Commit-Queue: edchin <edchin@chromium.org>
    > Reviewed-by: edchin <edchin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#744923}
    
    Bug: 870935
    Change-Id: I720f8e8dd8ed43ed2417d566454e8612cd518e43
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082914Reviewed-by: default avataredchin <edchin@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#746301}
    8c62eafd
BUILD.gn 2.29 KB