• Martin Kreichgauer's avatar
    fido: plumb AuthenticatorAttachment into CtapMakeCredentialRequest · 8cd3170a
    Martin Kreichgauer authored
    This adds an AuthenticatorAttachment field to
    CtapMakeCredentialRequest. The field is initialized by
    MakeCredentialRequestHandler from the equivalent field on its
    AuthenticatorSelectionCriteria parameter, and is consumed by
    WinNativeApiAuthenticator to initialize the equivalent parameter passed
    to the Windows WebAuthn API.
    
    Also moves the AuthenticatorAttachment enum out of
    AuthenticatorSelectionCriteria and into fido_constants.h, and fixes a
    common misspelling of attachment throughout the code.
    
    Also migrates the allowList and excludeList parameters of the Windows
    WebAuthn API to an updated version that respects the
    PublicKeyCredentialDescriptor's transports field.
    
    Bug: 898718
    Change-Id: I4dbc80929fcb6c4ff534822acd4b80410c14ae7f
    Reviewed-on: https://chromium-review.googlesource.com/c/1335785
    Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
    Reviewed-by: default avatarKim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Reviewed-by: default avatarAdam Langley <agl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608631}
    8cd3170a
make_credential_request_handler.cc 6.7 KB