• Meredith Lane's avatar
    Revert "Remove ignorable codepoints for FontFallback" · 8d07a719
    Meredith Lane authored
    This reverts commit 143d21fd.
    
    Reason for revert: Deterministically fails gfx_unittests on Mac 10.12
    First failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31106
    
    Original change's description:
    > Remove ignorable codepoints for FontFallback
    > 
    > Default ignorable codepoints should not be considered for
    > choosing a fallback font.
    > 
    > see:
    >  http://www.unicode.org/L2/L2002/02368-default-ignorable.pdf
    > """
    >   Default-ignorable codepoints are those that should be ignored
    >   by default in rendering (unless explicitly supported). They have
    >   no visible glyph or advance width in and of themselves, although
    >   they may affect the display, positioning, or adornment of
    >   adjacent or surrounding characters.
    > """
    > 
    > The API used to determine fallback fonts on Mac is
    > CTFontCreateForString(...)
    >   1) This API can returns .LastResort for an unknown text.
    >      We observed this behavior with Emoji (e.g. regional flags).
    >    see:
    >      https://unicode.org/policies/lastresortfont_eula.html
    > 
    >   2) The API is not able to match default ignorable codepoints
    >      like ZWJ and NZWJ. GetFallbackFont(...) was failing when
    >      an ignorable codepoints is present and the expensive
    >      GetFallbackFonts(...) is used instead.
    > 
    > 
    > Bug: 1036652
    > Change-Id: I12a81a0130b072f662547abd0d82f73c24a7b20d
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995501
    > Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
    > Reviewed-by: Robert Liao <robliao@chromium.org>
    > Reviewed-by: Dominik Röttsches <drott@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#732133}
    
    TBR=robliao@chromium.org,drott@chromium.org,etienneb@chromium.org
    
    Change-Id: I5c9fa4078a1519fc044536befd5d8a6ed0ea2604
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1036652
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004168Reviewed-by: default avatarMeredith Lane <meredithl@chromium.org>
    Commit-Queue: Meredith Lane <meredithl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#732252}
    8d07a719
font_fallback_mac.mm 3.28 KB