• Andrew Xu's avatar
    Polish on relocating the pinned app icon by mouse/gesture · 8d0825a9
    Andrew Xu authored
    When relocating the pinned app across pages, a proxy image view is
    created in ScrollableShelfView. The proxy image view has the identical
    bounds with ShelfView::|drag_view_|. However, |drag_view_|'s bounds
    are adjusted to fit into the targeting icon slot. It is why the
    dragged icon may move under the finger by itself. To fix the issue,
    the proxy image's bounds should rely on the mouse/gesture event's
    location.
    
    This CL also adds the animation to move the drag icon from event
    location to the ideal place after drag ends.
    
    Bug: 1031367
    Change-Id: I539abc1b97e061a50c2a53b1cc6b784e78c14983
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990565
    Commit-Queue: Andrew Xu <andrewxu@chromium.org>
    Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#729963}
    8d0825a9
shelf_view.cc 98 KB