• David Bokan's avatar
    [Reland] Make programmatic scrolls respect smooth scroll flag · 8d695b07
    David Bokan authored
    Programmatic smooth scrolls should also be instant if the smooth scroll
    flag is explicitly disabled.
    
    Previously landed in https://crrev.com/c/1536759
    
    To reland, this CL force enables the scroll animator in Blink web
    tests. Without this, the usual flow for determining if the animator is
    enabled is followed, which leads to inconsistencies. On Mac, the
    animator is enabled in Chrome but not in content shell. This leads to
    inconsistencies with other platforms (Mac tests ran without smooth
    scroll while Linux/Windows ran with) and ensuring we test what we ship.
    
    This change required some minor fixes to tests that assumed instant
    scroll on Mac (and uncovered one real bug).
    
    Bug: 944583
    Change-Id: I114d8b882d9855fbe0c43645575a1cdd7c3b6e61
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009842Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
    Reviewed-by: default avatarRobert Flack <flackr@chromium.org>
    Commit-Queue: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#735006}
    8d695b07
no-hover-during-smooth-keyboard-scroll.html 3.18 KB