• Tommy Martino's avatar
    [Cryptids] Fix Doodle overlap bug · 8d90c018
    Tommy Martino authored
    Cryptid rendering should be disabled whenever a Doodle is displayed.
    Currently, this condition is occasionally violated due to caching: we
    sometimes receive a cached response that there is no logo, followed
    by a fresh indication that actually there is one, but the first will have
    triggered cryptid rendering, causing overlapping.
    
    This CL solves this bug by invoking the OnLogoAvailable callback in the
    LogoService in the Revalidated case (which corresponds to a confirmation
    from the server that no logo is available), and tightening the
    conditions in NewTabPageLayout to pick up this new invocation.
    
    Bug: 1125889
    
    Change-Id: Iceb36ebd5aa6eaebe6ec4064951eac4c3510feb2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443890
    Commit-Queue: Tommy Martino <tmartino@chromium.org>
    Reviewed-by: default avatarMarc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#814415}
    8d90c018
logo_service_impl.cc 27.6 KB