• Guillaume Jenkins's avatar
    [Spellcheck] Enable the spelling service REST endpoint by default · 8db2c4b1
    Guillaume Jenkins authored
    The REST endpoint for the spelling service is ready to be fully launched.
    It has been enabled at 1% of stable for 2 weeks now, and between control
    and enabled on Dev/Canary/Beta/Stable:
    - HTTP status code metrics have been stable, though we have noticed
      between 0.5% and 0.9% of requests give a 403. We will need to keep an
      eye on those, but they do not warrant delaying the endpoint migration.
    - Proportion of failed requests has gone slightly down.
    - Mean latency (ms) of requests has gone slightly down.
    
    For those reasons, we are ready to fully migrate the spelling service to
    the new REST endpoint. Code cleanup will follow shortly, once we've
    confirmed that things are stable.
    
    Bug: 943108
    Change-Id: I19d394bed58db178dde682ffe168e651ee9e5125
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724666Reviewed-by: default avatarTim Volodine <timvolodine@chromium.org>
    Reviewed-by: default avatarsebsg <sebsg@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Commit-Queue: Guillaume Jenkins <gujen@google.com>
    Cr-Commit-Position: refs/heads/master@{#682385}
    8db2c4b1
spelling_service_client_unittest.cc 19.3 KB