• Daniel Bratell's avatar
    Remove variable shadowing in blink/modules/credentialmanager · 8de5a82d
    Daniel Bratell authored
    In an effort to reduce or even ban variable shadowing, this renames
    a variable to avoid such shadowing. I'm interested in prohibiting
    shadowing because I think it might prevent potential jumbo problems.
    
    The exact error this avoids is:
    third_party/blink/renderer/modules/credentialmanager/credentials_container.cc:180:23: error: declaration shadows a local variable [-Werror,-Wshadow]
        OriginAccessEntry access_entry(
                          ^
    third_party/blink/renderer/modules/credentialmanager/credentials_container.cc:166:21: note: previous declaration is here
      OriginAccessEntry access_entry(
                        ^
    
    Bug: 923510
    Change-Id: I61b11ecd489ed9842e1a9ebee9293050f7f1cde5
    Reviewed-on: https://chromium-review.googlesource.com/c/1478890Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Cr-Commit-Position: refs/heads/master@{#633742}
    8de5a82d
credentials_container.cc 29 KB