• xunjieli's avatar
    Do not invoke QuicHttpStream::DoCallback when in DoLoop · 8dff50ba
    xunjieli authored
    Latest crash dumps suggest that callback is invoked
    re-entrantly during QuicHttpStream::DoLoop(). This can be
    problematic because the caller can delete the
    QuicHttpStream when the callback is run. This CL changes
    QuicHttpStream::OnClose() to not invoke callback when
    already in DoLoop().
    
    This CL also adds a unit test which will crash without the
    change or the CHECKs.
    
    BUG=629043
    
    Review-Url: https://codereview.chromium.org/2163883004
    Cr-Commit-Position: refs/heads/master@{#407152}
    8dff50ba
quic_http_stream.cc 25.1 KB