GitLab

Revert of Change ExecLinkWrapper to not buffer all tool output (patchset #2 id:20001 of https://codereview.chromium.org/2558153002/ )

Reason for revert:
Reverting under suspicion for crbug.com/672841.

Original issue's description:
> Change ExecLinkWrapper to not buffer all tool output
>
> /verbose linking of chrome.dll creates over one GB of output. This
> causes ExecLinkWrapper to consume over two GB of memory which leads to
> an OOM failure in the 32-bit depot_tools python, and the loss of all
> of the valuable output. This change modifies ExecLinkWrapper to
> process the output one line at a time, thus avoiding the OOM.
>
> I've tested that this handles the 1.1 GB of output which the previous
> version of this function failed on and I've visually confirmed that the
> output looks the same - no extraneous blank lines, for instance, when
> displaying warnings, errors, or 1.9 million lines of verbose output.
>
> I also verified that the script stays idle when waiting for output -
> blocking on .readline().
>
> BUG=672182
>
> Committed: https://crrev.com/5d0d1b0bf01acb3ebe3a5ef27ebf2f3180ab1d1d
> Cr-Commit-Position: refs/heads/master@{#437126}

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=672182

Review-Url: https://codereview.chromium.org/2564893002
Cr-Commit-Position: refs/heads/master@{#437572}