• sangseok.jang's avatar
    Change the order of handling inkdrop and mouse event · 8e2c9408
    sangseok.jang authored
     InkDrop is handled before View::OnMouseEvent() in OnMouseEvent().
    So, If I want to override the functions associated with InkDrop(ex : CreateInkDropHighlight()),
    there is a problem with not getting the something appropriate(ex. Button::STATE).
    
     But, changing the order of handling inkdrop and mouse event causes crashes on windows.
    (See, http:://www.crbug.org/902279.)
    The cause of this crashes is calling views::OnMouseEvent() might delete "this".
    So We Check if it's being detroyed to avoid crashes.
    
    
    Bug: none
    Change-Id: I2051ddbff9d674418c42e8fd81fcd9a4ab47a984
    Reviewed-on: https://chromium-review.googlesource.com/c/1335068Reviewed-by: default avatarMohsen Izadi <mohsen@chromium.org>
    Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#611513}
    8e2c9408
ink_drop_host_view.cc 11 KB