• Evan Stade's avatar
    Reland "Remove ApplicationStatus usage from PhotoPicker." · 8e93a8e0
    Evan Stade authored
    This relands commit 78a7ace4.
    
    The original change somehow passed the CQ, and was reported to be
    flaky, but I believe it was deterministically failing. The failure
    was on a new assert in SelectFileDialog. This CL fixes the issue
    by moving the onPhotoPickerDismissed call into PhotoPickerListener,
    so that the tests, which don't involve SelectFileDialog, won't call into
    it. This also has the nice effect of removing the direct dependency
    from photo_picker on SelectFileDialog.
    
    Original change's description:
    > Remove ApplicationStatus usage from PhotoPicker.
    >
    > ApplicationStatus only works in //chrome. See crbug.com/470582
    >
    > Bug: 1110930
    > Change-Id: I71a6a5701aa40434588830cfcc6dee8ff6f5143a
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378633
    > Reviewed-by: David Trainor <dtrainor@chromium.org>
    > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    > Commit-Queue: Evan Stade <estade@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#803247}
    
    TBR=dtrainor@chromium.org
    
    Bug: 1123848,1110930
    
    Change-Id: Id5c0ae00b85d97cb5121acf1ece8d37ac8e2d021
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387624Reviewed-by: default avatarEvan Stade <estade@chromium.org>
    Reviewed-by: default avatarFinnur Thorarinsson <finnur@chromium.org>
    Commit-Queue: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#804053}
    8e93a8e0
DEPS 175 Bytes