• Evan Stade's avatar
    Revert "Reland "Implement ProtoChromePromptIPC."" · 8eee5e2e
    Evan Stade authored
    This reverts commit 5805ac7f.
    
    Reason for revert: breaking Windows compile:
    
    In file included from ../..\base/task/lazy_task_runner.h:17:
    ../..\base/task/task_traits.h(263,5): error: static_assert failed due to requirement 'has_thread_pool ^ has_extension' "Traits must explicitly specify a destination (e.g. ThreadPool or a named thread like BrowserThread)"
        static_assert(
        ^
    ../..\chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc.h(108,39): note: in instantiation of function template specialization 'base::TaskTraits::TaskTraits<base::MayBlock, void>' requested here
          base::CreateSequencedTaskRunner({base::MayBlock()});
                                          ^
    1 error generated.
    
    Original change's description:
    > Reland "Implement ProtoChromePromptIPC."
    > 
    > This is a reland of e5f1b06d
    > 
    > It was reverted in https://crrev.com/c/1760644 for causing test failures on CI
    > builders that couldn't be reproduced on other machines.
    > 
    > This patch disables the failing tests. A followup will reenable the tests with
    > extra debugging to diagnose the failures on the CI builders.
    > 
    > TBR=wfh
    > TBR_REASON=Reland of test-only proto change that was already reviewed.
    > 
    > Original change's description:
    > > Implement ProtoChromePromptIPC.
    > >
    > > Bug: 969139
    > > Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747
    > > Commit-Queue: Oliver Li <olivierli@chromium.org>
    > > Reviewed-by: Will Harris <wfh@chromium.org>
    > > Reviewed-by: Joe Mason <joenotcharles@google.com>
    > > Cr-Commit-Position: refs/heads/master@{#688357}
    > 
    > Bug: 969139
    > Change-Id: Iafdc22cc06fbedd5de73bf8bb7881fc46e01f350
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759154
    > Reviewed-by: Joe Mason <joenotcharles@google.com>
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Commit-Queue: Joe Mason <joenotcharles@google.com>
    > Cr-Commit-Position: refs/heads/master@{#689074}
    
    TBR=joenotcharles@google.com,wfh@chromium.org,olivierli@chromium.org
    
    Change-Id: I42f06162b45d41212816410027153f89f95a28f1
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 969139
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764124Reviewed-by: default avatarEvan Stade <estade@chromium.org>
    Commit-Queue: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#689151}
    8eee5e2e
mojo_chrome_prompt_ipc.h 5.63 KB