• tapted's avatar
    Reland of [Presentation API] Convert presentation.mojom to new wrapper types.... · 8f125bdd
    tapted authored
    Reland of [Presentation API] Convert presentation.mojom to new wrapper types. (patchset #1 id:1 of https://codereview.chromium.org/2196143002/ )
    
    Reason for revert:
    Didn't work. NaCl still crashing. Sadness :(
    
    Original issue's description:
    > Revert of [Presentation API] Convert presentation.mojom to new wrapper types. (patchset #5 id:80001 of https://codereview.chromium.org/2181163003/ )
    >
    > Reason for revert:
    > Suspect (not the first) for widespread NaCl test failures since
    > https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
    >
    > Errors like
    >
    > [4224:3200:0729/162247:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096)
    > ...
    >   Actual: "Plugin crashed. 'NaCl module crashed'"
    >
    > Wasn't r408782 or r408787. Running out of candidates..
    >
    > Original issue's description:
    > > [Presentation API] Convert presentation.mojom to new wrapper types.
    > >
    > > This converts presentation.mojom to use the new (std::) Mojo wrapper types:
    > > mojo::String => std::string
    > > mojo::Array => std::vector
    > >
    > > No behavior changes should ensue.
    > >
    > > Optional values are represented as base::Optional<Foo> with the new wrapper
    > > types requiring some additional changes.
    > >
    > > This work will simplify further changes for crbug.com/627655.
    > >
    > > BUG=627655
    > >
    > > Committed: https://crrev.com/59e7b40948030815a49af887b922b370ba048b8b
    > > Cr-Commit-Position: refs/heads/master@{#408781}
    >
    > TBR=dcheng@chromium.org,imcheng@chromium.org,mfoltz@chromium.org
    > NOTRY=true
    > BUG=627655
    >
    > Committed: https://crrev.com/43c746be32b2bfce5c3fd654894e4b7f7bf6387f
    > Cr-Commit-Position: refs/heads/master@{#408905}
    
    TBR=dcheng@chromium.org,imcheng@chromium.org,mfoltz@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=627655
    
    Review-Url: https://codereview.chromium.org/2197053002
    Cr-Commit-Position: refs/heads/master@{#408910}
    8f125bdd
BUILD.gn 6.15 KB