GitLab

There're multiple places that check kHideWebStoreIcon. [1] is the place
we're interested in.

We should change the pref value right after profile is available,
otherwise its value may already be used. (i.e. putting it in
OnSessionStateChanged is too late.)

Alternatively, we could check IsDeviceInDemoMode() when registering the
pref, but I'd like to avoid spreading the checks everywhere when
possible.

[1] https://cs.chromium.org/chromium/src/chrome/browser/history/top_sites_factory.cc?type=cs&q=khidewebstoreicon&sq=package:chromium&g=0&l=75

Bug: 885367
Change-Id: I9454acca4f02d91d5d85665f2cc3c29125ec7fb0
Reviewed-on: https://chromium-review.googlesource.com/c/1333121Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609053}