• Alexander Hendrich's avatar
    Revert "lacros: gnubby support for LaCrOS (hid_manager)" · 90a173bc
    Alexander Hendrich authored
    This reverts commit 95cff9e7.
    
    Reason for revert: failing tests, see https://crbug.com/1109621#c7
    
    Original change's description:
    > lacros: gnubby support for LaCrOS (hid_manager)
    > 
    > Because Gnubby and power gnubby in chromium would be considered as
    > HID devices, and this CL would enable HID devices support for LaCrOS.
    > 
    > Before this CL: Lacros would try to access /dev/hidraw*, but the
    > permission of it is root:hidraw 660, and lacros is running in chronos
    > user permission. By the way, CrOS it is using dbus to access the
    > permission_broker, and permission_broker would access these files for CrOS.
    > 
    > In this CL: Open a HidManager mojo between ash-chrome service and lacros service.
    > Lacros would use AddReceiver to add a receiver to ash-chrome's HidManager.
    > And the HidManager on ash-chrome would use permission_broker to access
    > /dev/hidraw* files. In this solution, we wouldn't need to compile the
    > permission_broker into lacros.
    > 
    > BUG=chromium:1109621
    > TEST=tested gnubby manually on soraka
    > 
    > Change-Id: I18cfe9b5e93e260b9347df4b57ebe12a621f44a8
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319089
    > Commit-Queue: joe Chou <yich@google.com>
    > Reviewed-by: Greg Kerr <kerrnel@chromium.org>
    > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
    > Reviewed-by: Reilly Grant <reillyg@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Reviewed-by: Erik Chen <erikchen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#800003}
    
    TBR=sky@chromium.org,jorgelo@chromium.org,reillyg@chromium.org,erikchen@chromium.org,kerrnel@chromium.org,yich@google.com
    
    Change-Id: I7cd325c2704a0b4cd18522acc977f3b45159b313
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:1109621
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366892Reviewed-by: default avatarAlexander Hendrich <hendrich@chromium.org>
    Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#800027}
    90a173bc
ash_chrome_service_impl.h 1.66 KB