• Christopher Thompson's avatar
    Refactor PageInfo EV handling · 90a711b8
    Christopher Thompson authored
    This refactors how Page Info handles showing the organization details
    for sites with EV certificates by moving creation of the subtitle text
    into the PageInfoBubbleView directly, since this is only used there.
    This fixes an issue where we were over-using the site_details_details_
    member to track both EV details and Safe Browsing details, causing the
    certificate button subtitle to get filled with the wrong text for sites
    that have an EV certificate *and* trigger SB warnings.
    
    As part of this, tracking the organization name in PageInfo is no
    longer necessary, so this also removes that entirely.
    
    This change also includes two new tests: a unit test for checking that
    the certificate button subtitle text is correctly set for sites with
    EV certificates, and a regression browser test for sites that have an
    EV cert and trigger SB warnings.
    
    Bug: 1014240
    Change-Id: I414cb07097fb5781c4b3a22ac7cca6e52bf14365
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863643Reviewed-by: default avatarMustafa Emre Acer <meacer@chromium.org>
    Commit-Queue: Christopher Thompson <cthomp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#706579}
    90a711b8
page_info.cc 45.4 KB