• Eric Karl's avatar
    Revert "Revert "Remove use of DeferredTextureImageData APIs and Support Decode to Scale"" · 90aeb8fe
    Eric Karl authored
    This reverts commit 74522773.
    
    Reason for revert: Have fixes for the original issues. Will land those after un-reverting.
    
    Original change's description:
    > Revert "Remove use of DeferredTextureImageData APIs and Support Decode to Scale"
    > 
    > This reverts commit 86c790e6.
    > 
    > Reason for revert: This is causing performance / memory regressions that are trickier to address than expected. Reverting this for now.
    > 
    > Original change's description:
    > > Remove use of DeferredTextureImageData APIs and Support Decode to Scale
    > > 
    > > We aren't benefitting from the complexity added by the
    > > DeferredTextureImageData APIs, and this API blocks us from using
    > > PaintImage::Decode's decode-to-scale functionality.
    > > 
    > > This change removes our usage of DeferredTextureImageData APIs,
    > > instead using SkImage::makeTextureImage to handle upload. Additionally,
    > > we now use the PaintImage::Decode API, adding decode-to-scale support.
    > > 
    > > Bug: 773799
    > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
    > > Change-Id: Ia5f480213c3a5c8225ccd289aa2c081056840f94
    > > Reviewed-on: https://chromium-review.googlesource.com/713593
    > > Reviewed-by: vmpstr <vmpstr@chromium.org>
    > > Commit-Queue: Eric Karl <ericrk@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#517206}
    > 
    > TBR=vmpstr@chromium.org,ericrk@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 773799
    > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
    > Change-Id: Ie4493559e334100f03dfed1dfb7a408fc26a33e0
    > Reviewed-on: https://chromium-review.googlesource.com/830587
    > Commit-Queue: Eric Karl <ericrk@chromium.org>
    > Reviewed-by: Eric Karl <ericrk@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#524613}
    
    TBR=vmpstr@chromium.org,ericrk@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 773799
    Change-Id: Ic4492707672b8652bd3b102d3918399afb5321b4
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/847030
    Commit-Queue: Eric Karl <ericrk@chromium.org>
    Reviewed-by: default avatarEric Karl <ericrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#526601}
    90aeb8fe
gpu_image_decode_cache.cc 57.5 KB