• Meredith Lane's avatar
    Revert "[Sampling profiler] Implement signal-based stack copying in //base/profiler" · 91aab85b
    Meredith Lane authored
    This reverts commit ffff90fd.
    
    Reason for revert: Consistently failing on multiple ChromeOS bots. https://crbug.com/1018615
    
    Original change's description:
    > [Sampling profiler] Implement signal-based stack copying in //base/profiler
    > 
    > This CL extracts the core stack copying parts of
    > tracing::StackUnwinderAndroid into the dedicated base::StackCopierSignal
    > class, and adapts it for direct use by the sampling profiler stack
    > unwinding implementation. This drops some unneeded code; updates the code
    > to run on 32-bit Android, 64-bit Android, and 64-bit Linux platforms;
    > and converts the code to use C++ atomics.
    > 
    > The StackUnwinderAndroid implementation will eventually be replaced
    > wholesale by the sampling profiler implementation for Android. This CL
    > does not attempt to reuse the extracted stack copying implementation on
    > its own, in order to avoid introducing bugs in StackUnwinderAndroid due
    > to the differing implementations.
    > 
    > TBR=gab@chromium.org
    > 
    > Bug: 988579
    > Change-Id: I0293771679c5deae69fdbb007d8828ead575ee0f
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872967
    > Reviewed-by: Mike Wittman <wittman@chromium.org>
    > Reviewed-by: Gabriel Charette <gab@chromium.org>
    > Reviewed-by: Charlie Andrews <charliea@chromium.org>
    > Reviewed-by: ssid <ssid@chromium.org>
    > Commit-Queue: Mike Wittman <wittman@chromium.org>
    > Commit-Queue: Gabriel Charette <gab@chromium.org>
    > Auto-Submit: Mike Wittman <wittman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#709597}
    
    TBR=gab@chromium.org,wittman@chromium.org,ssid@chromium.org,charliea@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 988579
    Change-Id: Ib62446f431d971f2403b1fb9fcebaa130559c698
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882190Reviewed-by: default avatarMeredith Lane <meredithl@chromium.org>
    Commit-Queue: Meredith Lane <meredithl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#709785}
    91aab85b
thread_delegate_posix.cc 3.04 KB