• Balazs Engedy's avatar
    Revert "Add viewport scroll information to PDFAccessibilityTree" · 91f877ca
    Balazs Engedy authored
    This reverts commit a351b484.
    
    Reason for revert: MemorySanitizer: use-of-uninitialized-value.
    
    New struct members added to PP_PrivateAccessibilityViewportInfo seem to remain uninitialized in PdfAccessibilityTreeTest.TestZoomAndScaleChanges.
    
    Original change's description:
    > Add viewport scroll information to PDFAccessibilityTree
    > 
    > This CL adds following information to PDFAccessibilityTree
    > - ax::mojom::IntAttribute::kScrollXMin
    > - ax::mojom::IntAttribute::kScrollXMax
    > - ax::mojom::IntAttribute::kScrollX
    > - ax::mojom::IntAttribute::kScrollYMin
    > - ax::mojom::IntAttribute::kScrollYMax
    > - ax::mojom::IntAttribute::kScrollY
    > 
    > It enables partial implementation of IScrollProvider, following methods
    > will work with this change
    > - IScrollProvider::get_HorizontallyScrollable
    > - IScrollProvider::get_VerticallyScrollable
    > - IScrollProvider::get_HorizontalScrollPercent
    > - IScrollProvider::get_VerticalScrollPercent
    > 
    > This information is required by Screen readers to announce the current
    > scroll position and extent of scroll to the user.
    > 
    > Tests: The best way to test this change will be through browser tests.
    > However, it requires the second part of the change, detailed in the
    > associated bug, to be completed.
    > 
    > Bug: 1034521
    > Change-Id: I11067b2af4d5bd73e62d89c8ce86fb00b5f3f7ec
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969412
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Lei Zhang <thestig@chromium.org>
    > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
    > Commit-Queue: Virender Singh <virens@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#727858}
    
    TBR=dcheng@chromium.org,thestig@chromium.org,manojb@microsoft.com,mohitb@microsoft.com,virens@microsoft.com,ankk@microsoft.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1034521
    Change-Id: If82ca15040193884cd03891419d7065da425fcf6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985011Reviewed-by: default avatarBalazs Engedy <engedy@chromium.org>
    Commit-Queue: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#727956}
    91f877ca
preview_mode_client.h 2.96 KB