• manukh's avatar
    [omnibox] [bookmark-paths] Allow path matching in TitledUrlIndex lookup. · 92134fdb
    manukh authored
    Currently, bookmark suggestions are limited to title & URL matches. E.g
    the input 'planets jupiter' won't suggest a bookmark titled 'jupiter' in
    a directory 'planets'.
    
    This is the 4th of 5 CLs implementing bookmark-paths which will allow
    inputs to match bookmark paths (without contributing to the bookmark
    suggestion's score).
    
    This CL updates TitledUrlIndex::GetResultsMatching to (optionally)
    include bookmarks that match the path. This won't include bookmarks that
    *only* match the path. E.g., this would allow the bookmark 'path/title'
    to match the query 'path title' but not the query 'path'.
    
    Bug: 1129524
    Change-Id: I745009139dde14c49e7a958ff5a105d0b39bdeb7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441153
    Commit-Queue: manuk hovanesian <manukh@chromium.org>
    Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#824549}
    92134fdb
bookmark_model_unittest.cc 65.7 KB