• Andrew Grieve's avatar
    Reland #2 of "Android: Updates to warnings-as-errors when building" · 92b6f65c
    Andrew Grieve authored
    This reverts commit 561b40b5.
    
    Reason for reland: Other culprit CL reverted:
    https://chromium-review.googlesource.com/c/chromium/src/+/2310131
    
    Original change's description:
    > Revert #2 of "Android: Updates to warnings-as-errors when building"
    > 
    > This reverts commit 3a98cccc.
    > 
    > Reason for revert: The reland also broke the tree.
    > 
    > Original change's description:
    > > Reland "Android: Updates to warnings-as-errors when building"
    > > 
    > > This reverts commit 57deecbb.
    > > 
    > > Reason for reland: Suppressed cast lint warning
    > > 
    > > Reverted in: 339e6581.
    > > 
    > > > Original change's description:
    > > > > Android: Updates to warnings-as-errors when building
    > > > >
    > > > > * Delete java_warnings_as_errors
    > > > > * Use treat_warnings_as_errors for android rules
    > > > >   * warnings-as-errors is now default true for debug builds
    > > > > * Add --warnings-as-errors to proguard.py, dex.py, bytecode_processor.py
    > > > >   so that these warnings can all be turned off locally.
    > > > > * Made build_utils.CheckOutput fail by default when stderr or stdout is
    > > > >   printed. This should prevent build logs from creaping in.
    > > > > * Added "you should use treat_warnings_as_errors=false" into error
    > > > >   message when builds fail due to warnings.
    > > 
    > > TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org
    > > 
    > > Bug: 1029357
    > > Change-Id: I56c1349c6e823737aa8a59a8e961e5a518667ba0
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308868
    > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    > > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#790410}
    > 
    > TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org
    > 
    > Change-Id: I4721f016821d3675e389740d7d2d59e787ff9304
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1029357
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310392
    > Reviewed-by: Tommy Martino <tmartino@chromium.org>
    > Commit-Queue: Tommy Martino <tmartino@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#790453}
    
    TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,tmartino@chromium.org,andruud@chromium.org
    
    Change-Id: Ib19547f2099ec59b9b00b43a9f9ae5d9ea23e28e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1029357
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309813Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
    Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#790459}
    92b6f65c
config.gni 12.7 KB