• David 'Digit' Turner's avatar
    android: store compressed locales under assets/locales/ · 92e8223d
    David 'Digit' Turner authored
    This patch simply moves the location where the compressed
    locale .pak files are stored within the final Chrome and
    Monochrome APKs, from assets/<locale>.pak to
    assets/locales/<locale>.pak
    
    The reason to do this is to allow language-dependent
    splits in the future, which will require apkbuilder.py
    to support an option to place the files under a
    directory like assets/locales#<lang>/<locale>.pak,
    where <lang> is the language code of each corresponding
    locale.
    
    Note that these files are never accessed directly from
    Chromium, instead they are extracted at startup time
    if needed to the application's private data directory,
    and the uncompressed file there is what Chrome will
    later memory-map from native code.
    
    In detail:
    
    - Modify chrome/android/BUILD.gn to ensure that the
      compressed locale pak files are placed under
      assets/locales/
    
    - Modify write_build_config.py to not use the directory
      of locale pak files when generating the Java locale
      lists for COMPRESSED_LOCALES and UNCOMPRESSED_LOCALES.
    
    - Modify ResourceBundle.java to deal with the new list
      format when looking for uncompressed locales.
    
    - Modify ResourceExtractor.java to deal with the new
      list format and the new locations.
    
    BUG=820459
    R=agrieve@chromium.org,dtrainor@chromium.org,tedchoc@chromium.org
    
    Change-Id: Ia0caef3514a1ccfa72fe0ab1ff6fc1bf418377a6
    Reviewed-on: https://chromium-review.googlesource.com/1010352
    Commit-Queue: David Turner <digit@chromium.org>
    Reviewed-by: default avataragrieve <agrieve@chromium.org>
    Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
    Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551332}
    92e8223d
BUILD.gn 53.1 KB