GitLab

OverviewSession::OnDisplayRemoved is unreachable and contains a TODO
that describes behavior contrary to the current design decisions. Also,
when a display is added, overview ends (as expected) only because of
OverviewSession::OnShelfAlignmentChanged; the present CL adds
OverviewSession::OnDisplayAdded to improve code maintainability.

Test: ash_unittests OverviewSessionTest.Shutdown
Test: ash_unittests OverviewSessionTest.AddDisplay
Test: ash_unittests OverviewSessionTest.RemoveDisplay
Test: ash_unittests OverviewSessionTest.RemoveDisplayWithAnimation
Change-Id: If2a282364b72f5fcedac5bdbb7a9f0c1ab8ebd97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743114Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686563}