• Donn Denman's avatar
    Revert "Browser test to exercise DoH against external servers" · 9338addd
    Donn Denman authored
    This reverts commit 261096cf.
    
    Reason for revert: Speculative revert of this CL since it may be causing many test failures.  See issue 1038953.
    
    BUG=1038953
    
    Original change's description:
    > Browser test to exercise DoH against external servers
    > 
    > This change adds a non-hermetic manual browser test to verify
    > Chrome's DoH implementation against a handful of external
    > DoH servers. The test loops through each server, and
    > attempts to load a test URL. Fallback to Do53 is
    > disabled, so a successful navigation indicates that DoH passed.
    > 
    > A new setter set_allow_network_access_to_host_resolutions has
    > been added to BrowserTestBase to allow browser tests to opt-in
    > to using the full host resolver stack (instead of the mock host
    > resolver). This mode then invokes
    > SetAllowNetworkAccessToHostResolutions() on the NetworkServiceTest
    > interface to disable the test host resolver.
    > 
    > Bug: 1032710
    > Change-Id: I8e9e029e69a9e8281adb23e55179d9dd94707ef5
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961006
    > Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org>
    > Reviewed-by: Eric Orth <ericorth@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#727778}
    
    TBR=sky@chromium.org,ericorth@chromium.org,kaustubhag@chromium.org,dalyk@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1032710
    Change-Id: I1e7628f22b55f9a884926b05e47fff25e2368a27
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987274Reviewed-by: default avatarDonn Denman <donnd@chromium.org>
    Commit-Queue: Donn Denman <donnd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#728374}
    9338addd
browser_test_base.cc 31.7 KB