• Tom Anderson's avatar
    [Reland] Remove absolute paths from build files · 93e774da
    Tom Anderson authored
    > This CL removes all absolute paths to src and all usages of the out directory
    > name from all ninja files on most Linux builds.
    >
    > This means it's possible to mount your src directory at different locations and
    > still have incremental builds work.  You can also rename your out directory.
    >
    > BUG=None
    > R=dpranke,caitkp,rockot
    >
    > Reviewed-on: https://chromium-review.googlesource.com/1091457
    > Reviewed-by: Cait Phillips <caitkp@chromium.org>
    > Reviewed-by: Ken Rockot <rockot@chromium.org>
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567020}
    
    This reland includes a fix for the breakage on Google Chrome Linux [1].  The
    issue was listing a relative path in the gn "inputs" variable.  For some reason,
    despite
      inputs = [ "../../chrome/android/profiles/afdo.prof" ]
    ninja errored with
      '../../build/chrome/android/profiles/afdo.prof' ... missing and no known rule
      to make it
    It's unclear why "build" was added in the path, but simply using the non-rebased
    path for inputs fixes the issue.
    
    [1] https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/32416
    
    R=dpranke
    TBR=rockot,caitkp
    BUG=None
    
    Change-Id: I2c5f9148ea8b1a8354a31f6bcc8ae4b8924c0b45
    Reviewed-on: https://chromium-review.googlesource.com/1100168Reviewed-by: default avatarThomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#567139}
    93e774da
generate_expired_histograms_array.gni 1.66 KB