• Lukasz Anforowicz's avatar
    Exclude the nonce from ScopedOriginCrashKey value. · 949141f8
    Lukasz Anforowicz authored
    Before the current CL, the nonce in the crash key is unique in each
    crash report, making it more difficult to aggregate the data.
    
    Additionally, after r783795 landed, we started seeing new values of
    request_initiator_site_lock crash key associated with
    https://crbug.com/1056949, but unfortunately the interesting part of the
    crash key was truncated, making it impossible to distinguish between
    mhtml.subframe.invalid VS browser.initiated.invalid VS
    error.page.invalid.  For example, before the current CL, the crash key
    values might look like the following (truncated to 64 characters):
    
        null [internally: (646094991C8C225E35D3FEE319396B15) derived fro
    
    After the current CL, the crash key value omits the nonce:
    
        null [internally: derived from https://error.page.invalid]
    
    Bug: 1056949
    Change-Id: Ib676e4484f1814a494b5359db13cfc9160233b63
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284044
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#786422}
    949141f8
origin_unittest.cc 39.5 KB