• Daniel Bratell's avatar
    Clarify which mojom namespace to use inside metrics · 94caa8b9
    Daniel Bratell authored
    There is both a ::mojom namespace and a ::metrics::mojom namespace
    so inside metrics its best to qualify which is intended or
    name lookup will depend on what the compiler happens to be
    aware of.
    
    In particular, in some jumbo builds "mojom" resolved to
    "::metrics::mojom" while in other builds where the compiler was
    unaware of ::metrics::mojom, it instead resolved to "::mojom".
    
    This is probably one of the reasons there is a style guide
    instruction to not have sub namespaces with the same name as a
    common top level namespace.
    
    Change-Id: I06545d34fac67b5f3f42fa1821eb33d381e04a41
    Reviewed-on: https://chromium-review.googlesource.com/c/1485934Reviewed-by: default avatarJesse Doherty <jwd@chromium.org>
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Cr-Commit-Position: refs/heads/master@{#635562}
    94caa8b9
tab_stats_tracker.cc 19.3 KB