• Nektarios Paisios's avatar
    Remove ignored views from the accessibility tree visible to platform APIs · 9547d4ed
    Nektarios Paisios authored
    This patch is the first, (not user visible), fix for a bug with the reading of lines in NVDA.
    When the screen reader focus is in the accessibility tree for Views, such as in a context menu, a toolbar
    or the main application's menu, the "Read Line" command (NVDAKey+Up) doesn't always read the currently focused item.
    
    We were exposing ignored views in the accessibility tree that was exposed to platform APIs.
    As a result, platform specific code under ui/accessibility was building IA2 and ATK hypertext for ignored nodes,
    while text navigation code in the same component was trying to locate non-existent line boundaries in that hypertext.
    
    A followup patch will ensure that the names of Views that come from their contents
    are clearly marked as such.
    
    R=dmazzoni@chromium.org, aleventhal@chromium.org
    
    AX-Relnotes: n/a.
    
    Change-Id: I5fdae5714b10b10db3dc5b5dcf22d118f322e9e7
    Bug: 1098528
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435645
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#828873}
    9547d4ed
view_accessibility.h 8.59 KB