• Jesse McKenna's avatar
    Revert "Use consistent DLL to detect Application Verifier" · 956f8294
    Jesse McKenna authored
    This reverts commit fd8fe93c.
    
    Reason for revert: this change is causing chrome.exe to crash on startup. I received a report that chrome.exe looked for the string constant in memory and encountered some kind of error which caused it to crash. I will roll back for now to investigate.
    
    Original change's description:
    > Use consistent DLL to detect Application Verifier
    > 
    > To detect whether Application Verifier is running,
    > sandbox/win/src/target_interceptions.cc checks if vrfcore.dll is loaded,
    > while sandbox/win/src/handle_closer_agent.cc checks for verifier.dll.
    > 
    > This change makes both use verifier.dll, to be consistent and remove any
    > confusion around whether these two are checking for the same thing (they
    > are).
    > 
    >       Open Application Verifier
    >       File > Add Application > chrome.exe (any chrome.exe binary works)
    >       Under 'Tests', uncheck everything but Basics > Handles, then Save
    >       Run chrome.exe with this change; it works normally
    >         (on versions without lines 176-177, no pages will load)
    >       Return to Application Verifier
    >       Right-click chrome.exe > Delete Application, then Save
    >         (so Chrome runs normally again)
    > 
    > Test: Manual
    > Change-Id: If97a1115373c394f0cbbf1d31d3ca7b60549bbee
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776781
    > Commit-Queue: Jesse McKenna <jessemckenna@google.com>
    > Reviewed-by: Greg Thompson <grt@chromium.org>
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#700323}
    
    TBR=brucedawson@chromium.org,wfh@chromium.org,grt@chromium.org,jessemckenna@google.com
    
    Change-Id: I79f41f6e93813befaf4e49604f7dcc1f8c1ddb48
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828234Reviewed-by: default avatarDavid Bienvenu <davidbienvenu@chromium.org>
    Commit-Queue: Jesse McKenna <jessemckenna@google.com>
    Cr-Commit-Position: refs/heads/master@{#700493}
    956f8294
win_util.h 11.3 KB