• Julie Jeongeun Kim's avatar
    Reland "[a11y] Add scrolling action to PP_PDF_SET_SELECTION" · 95dbdce3
    Julie Jeongeun Kim authored
    This is a reland of 9b07e5e0 with
    a fix of a failure on Linux MSan Test builder.
    
    Added an initial value for |action_data.target_rect| to
    AccessibilityTest.TestSelectionActionHandling.
    
    Original change's description:
    > [a11y] Add scrolling action to PP_PDF_SET_SELECTION
    >
    > This CL adds scrolling when PDFiumEngine::HandleAccessibilityAction
    > is called with PP_PDF_SET_SELECTION and the selection is not
    > visible since Blink triggers also scrolling with setting selection.
    > So, this change makes PDF document scroll the page when a selection
    > is set.
    >
    > AX-Relnotes: When SetSelection action is handled on pdf, it also
    > triggers scrolling if the selection is not in the visible area.
    > For instance, atk_text_set_caret_offset() on pdf scrolls the page
    > if the text is not in the view port.
    >
    > Bug: 993456
    > Change-Id: I8323eff293b3216e2b862f8df3e896380b1c9945
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573975
    > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    > Reviewed-by: K. Moon <kmoon@chromium.org>
    > Reviewed-by: Martin Robinson <mrobinson@igalia.com>
    > Commit-Queue: Julie Kim <jkim@igalia.com>
    > Cr-Commit-Position: refs/heads/master@{#835994}
    
    Bug: 993456
    Change-Id: Ie7c683d062c50d4eade2b5fb4990bc6ca2be12ba
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586644Reviewed-by: default avatarK. Moon <kmoon@chromium.org>
    Commit-Queue: Julie Kim <jkim@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#836377}
    95dbdce3
pdf_ax_action_target.cc 7.29 KB