• Tim Schumann's avatar
    Revert "Remove synchronous blocking from PipelineImpl::Stop() - take 2." · 964cc812
    Tim Schumann authored
    This reverts commit 63dd5d45.
    
    Reason for revert: Causes flakes in the following tests:
    virtual/video-surface-layer/media/track/track-cue-rendering-position-auto.html
    
    virtual/video-surface-layer/media/controls/volumechange-stopimmediatepropagation.html
    
    Bug: 909586
    
    Original change's description:
    > Remove synchronous blocking from PipelineImpl::Stop() - take 2.
    > 
    > We should be able to avoid this with careful use of a trampoline
    > through the media thread after PipelineImpl::Stop() completes.
    > 
    > This is an updated version of the last CL:
    > https://chromium-review.googlesource.com/c/chromium/src/+/1336659
    > 
    > The difference is we now also preserve the RendererFactorySelector
    > until after renderer shutdown. This passes all the failing tests
    > I could find locally.
    > 
    > BUG=521176, 905506
    > TEST=passes cq.
    > R=​sandersd
    > 
    > Change-Id: I86c4814a91ee6c41f20f6bb8a05859ac44171d7e
    > Reviewed-on: https://chromium-review.googlesource.com/c/1351791
    > Reviewed-by: Dan Sanders <sandersd@chromium.org>
    > Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#611305}
    
    TBR=dalecurtis@chromium.org,sandersd@chromium.org
    
    Change-Id: I8d70751211f938756bf5b98e86b298f4fe921617
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 521176, 905506
    Reviewed-on: https://chromium-review.googlesource.com/c/1352326Reviewed-by: default avatarTim Schumann <tschumann@chromium.org>
    Commit-Queue: Tim Schumann <tschumann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#611602}
    964cc812
webmediaplayer_impl.cc 124 KB