• Lukasz Anforowicz's avatar
    Stop ignoring base::Bind args (thinking the parameters are references). · 96e7ad75
    Lukasz Anforowicz authored
    Given:
    
        template <typename... TArgs>
        void GetViaTemplateParamPackRValue(TArgs&&... param_pack) {}
    
    Any argument passed to GetViaTemplateParamPackRValue will be matched by
    
        forEachArgumentWithParam(..., parmVarDecl(hasType(referenceType())))
    
    Before this CL, the scenario above has undesirably led to marking
    fields used as such arguments as "in-out-param-ref" and skipped.
    
    After this CL, ParmVarDecl's with RValueReferenceType are excluded
    from the matcher than emits "in-out-param-ref" field filters.
    
    Bug: 1069567
    Change-Id: I183a96f5dea30b90737727a6453f4678c4753a72
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239681
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#782147}
    96e7ad75
gen-in-out-arg-test.cc 3.1 KB