• Alexandre Courbot's avatar
    Revert "Replace drmModeSetCrtc by Atomic APIs" · 9736e4a7
    Alexandre Courbot authored
    This reverts commit 12bbfb47.
    
    Reason for revert: this breaks video_decode_accelerator_unittest (and probably others) when built in Debug mode:
    
    hardware_display_plane_manager.cc(368)] Check failed: state.properties.active.id.
    
    Original change's description:
    > Replace drmModeSetCrtc by Atomic APIs
    > 
    > If the device supports atomic APIs, use drmModeAtomicCommit to modeset
    > and disable instead of drmModeSetCrtc.
    > Abstracted Modeset and Disabled code to HDPM to handle both atomic and
    > legacy call.
    > Updated tests to support Connector and CRTC props.
    > 
    > BUG=987274
    > TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps,
    > HardwareDisplayPlaneManagerLegacyTest.Modeset,
    > HardwareDisplayPlaneManagerLegacyTest.DisableModeset,
    > HardwareDisplayPlaneManagerAtomicTest.DisableModeset, Tested on
    > Nautilus(Intel), Grunt(AMD) and Cave(Legacy).
    > 
    > Change-Id: Ic6d3873c94cb657fbe8de6dcd0faf97aeea05bd5
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020809
    > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
    > Commit-Queue: Mark Yacoub <markyacoub@google.com>
    > Auto-Submit: Mark Yacoub <markyacoub@google.com>
    > Cr-Commit-Position: refs/heads/master@{#736021}
    
    TBR=dnicoara@chromium.org,dcastagna@chromium.org,markyacoub@google.com
    
    Change-Id: Ic116c75d0eb1d81dfe45b6bcd76bcc2e27aaa4e6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 987274
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026779Reviewed-by: default avatarAlexandre Courbot <acourbot@chromium.org>
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#736278}
    9736e4a7
crtc_controller.cc 4.76 KB