• Liquan (Max) Gu's avatar
    //components payment template not to depend on //chrome resources · 97832b23
    Liquan (Max) Gu authored
    Context:
    Currently, //components payment targets depends on //chrome resources
    ic_edit_24dp.png, product_logo_name.png, fre_product_logo.png. It's
    because the payment view templates depend on them. This CL is written
    to break the dependencies.
    
    Changes:
    * this CL changes to set fre_product_logo and product_logo_name
    programmatically from //chrome, from having them referenced in
    //components templates.
    * ic_edit_24dp.png is moved from //chrome into //components
    
    Before:
    The two //components xml templates depends on the //chrome resources
    ic_edit_24dp.png, product_logo_name.png, fre_product_logo.png.
    
    After:
    No //components payment targets depends on the //chrome resources.
    
    Bug: 1141076
    
    Change-Id: Idea99bdb55d1dd633a540eee4d2db27e2c471634
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490162
    Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
    Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
    Reviewed-by: default avatarSahel Sharify <sahel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#820460}
    97832b23
chrome_java_resources.gni 54.3 KB